Remove unnecesary aws-sdk gems #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the gem
aws-sdkin favor of the S3 specific one (aws-sdk-s3).As reported in thoughtbot/paperclip#2484 an initializer like the one in
assets/aws.rbwas necessary for the gem to work correctly, but since paperclip6.0.0, it is no longer needed because of the improvement introduced in thoughtbot/paperclip#2481. In this PR the initializer is removed.As adding the initializer was the only thing that the whole
aws_sdkrecipe was doing, besides adding the old gem, it is also removed in this PR.